fix: ip check fallback following axios regression #2054
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolasburtey
changed the title
dolcalmi
previously requested changes
Dec 20, 2022
| @@ -17,28 +23,28 @@ export const updateAccountIPsInfo = async ({ | |||
| logger: Logger | |||
| }): Promise<void | RepositoryError> => | |||
| asyncRunInSpan( | |||
| "app.users.updateAccountIPsInfo", | |||
| "app.accounts.updateAccountIPsInfo", | |||
There was a problem hiding this comment.
this wrapper is not necessary because in sessionContext we are using Accounts.updateAccountIPsInfo which is already a wrapper
Comment on lines
95
to
100
| const ipFetcherInfoForOtel = JSON.parse(JSON.stringify(ipFetcherInfo)) | ||
|
|
||
| for (const key in ipFetcherInfoForOtel) { | ||
| ipFetcherInfoForOtel["proxycheck." + key] = ipFetcherInfoForOtel[key] | ||
| delete ipFetcherInfoForOtel[key] | ||
| } |
There was a problem hiding this comment.
this can be replaced by a .map
nicolasburtey
dismissed
dolcalmi’s stale review
comment should has been addressed
dolcalmi
approved these changes
Dec 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
axios had a regression that made proxycheck call failed: axios/axios#5306
this prior PR fixes the proxycheck issue: eca59ab
now most
IPTypeare not populated with the correct info, so as a result the rewards are not working.this PR will make a call back to proxychecker if the relevant info is not present.
also, it adds proper open telemetry info