Fix #515 Add required option to decorator plugin #518
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
wyuenho
commented
Sep 8, 2018
wyuenho
commented
- Upgrade babel@7.0.0-rc1 to babel@7.0.0
- Remove add-module-exports plugin requirement for bin scripts
- Upgrade eslint and flow-bin
|
This is bug is caused by babel/babel#8465, see babel/babel#8562 for more info. |
|
Please don't merge this yet, I'd like to remove my evil work twin from this PR when I get back home tonight... left my private key at home... |
|
Haha, okay! Well, I'm glad you are restrictive with your secrets. Thanks a bunch for working on this. ❤️ |
- Upgrade babel@7.0.0-rc1 to babel@7.0.0 - Use decorator-legacy for the parser - Remove add-module-exports plugin requirement for bin scripts - Upgrade eslint and flow-bin
|
You can merge this now :) |
trotzig
approved these changes
Sep 10, 2018
| "plugins": [ | ||
| "add-module-exports", |
There was a problem hiding this comment.
It's possible that this will break the Atom plugin (which I think assumes a commonjs export). In any case, I'll deal with that after the release.
|
This PR was included in the 3.1.1 release. 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.