Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix float yaml loading #5

Merged
merged 3 commits into from
Oct 13, 2022
Merged

Fix float yaml loading #5

merged 3 commits into from
Oct 13, 2022

Conversation

Gaikanomer9
Copy link
Owner

Enforce using decimals internally for parsed SLO targets and similar data

@Gaikanomer9 Gaikanomer9 self-assigned this Oct 10, 2022
@mmazur
Copy link
Collaborator

mmazur commented Oct 11, 2022

Waiting for the discussed changes and I can merge.

@Gaikanomer9
Copy link
Owner Author

The solution for resolving decimals this way is based on the source code: yaml/pyyaml#173 and this discussion https://github.com/yaml/pyyaml/blob/957ae4d495cf8fcb5475c6c2f1bce801096b68a5/lib/yaml/resolver.py#L177

Basically, decimal is not supported by default by the library and we need to add the implicit decimal resolver.

@mmazur mmazur merged commit 37a561d into main Oct 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants