This repository has been archived by the owner on Aug 18, 2021. It is now read-only.
Upgrade node #152
Merged
Upgrade node #152
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
December 16, 2017 17:38
- Updated dependency versions in package.json - Updated the Node and NPM version to use with the project. - NPM version update added package-lock.json - Added meta schema to AJV to support json-schema-draft-04.json
- This promise code was causing the executing of Mocha tests to hang. The rewrite/clean up not only made it simpler but also helped avoid the test hanging
- Moment was being used incorrectly and a deprication warning was printed out. This code change fixes both deprecation error and the incorrect use of the library.
- Mocha 4.0.x no longer force quits. The interval creation would have the effect of not letting Mocha finish its execution. Now the interval is only created if app.js is not used as a module. - The NewRelic require statement was also moved for the same reason as the interval creation.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
We were using an old LTS version of Node. Once Cloud.gov started supporting the newer LTS version (LTS/carbon - v8.9.3) it only made sense to update our version of Node and NPM.
This also let us update node modules that were outdated and flagged by Gemnasium.
This PR fixes/implements the following bugs/features
Explain the motivation for making this change. What existing problem does the pull request solve?
The main motivation is to resolve the security vulnerabilities and warnings pointed out by Gemnasium. Many of the node modules versions where behind a number of releases.
Another main motivation was the added support in Cloud.gov for a more recent Node LTS (lts/carbon - 8.9.3). This gives us access to NPM 5, which code-gov-web is using.
Test plan (required)
All test are passing in CircleCI
Closing issues
Fixes #151