Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

avoid "done" message when there is no request #2808

Merged
merged 4 commits into from May 20, 2024
Merged

avoid "done" message when there is no request #2808

merged 4 commits into from May 20, 2024
+32 −0

Conversation

weiyuan-jiang
Copy link
Contributor

@weiyuan-jiang weiyuan-jiang commented May 3, 2024 •
edited

Types of change(s)

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Trivial change (affects only documentation or cleanup)

Checklist

  • Tested this change with a run of GEOSgcm
  • Ran the Unit Tests (make tests)

Description

This PR addressed the issue #2792

Related Issue

@weiyuan-jiang weiyuan-jiang added the 0 Diff The changes in this pull request have verified to be zero-diff with the target branch. label May 3, 2024
@weiyuan-jiang
Copy link
Contributor Author

@bena-nasa Can you test your cases with this branch?

@bena-nasa
Copy link
Collaborator

I'll look at this today

@tclune tclune marked this pull request as ready for review May 20, 2024 13:12
@tclune tclune requested a review from a team as a code owner May 20, 2024 13:12
@tclune tclune self-assigned this May 20, 2024
tclune
tclune previously approved these changes May 20, 2024
View reviewed changes
@tclune tclune self-requested a review May 20, 2024 19:10
@mathomp4 mathomp4 merged commit 8ddd7bc into develop May 20, 2024
11 of 22 checks passed
@mathomp4 mathomp4 deleted the feature/wjiang/no_done branch May 20, 2024 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tclune tclune tclune approved these changes

Assignees

@tclune tclune

Labels
0 Diff The changes in this pull request have verified to be zero-diff with the target branch.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@weiyuan-jiang @bena-nasa @tclune @mathomp4