CI: Release workflow #237
CI: Release workflow #237
Conversation
|
|
||
| - name: Import GPG key | ||
| id: sign | ||
| uses: crazy-max/ghaction-import-gpg@01dd5d3ca463c7f10f7f4f7b4f177225ac661ee4 |
There was a problem hiding this comment.
I think we need to set the GPG_PRIVATE_KEY secret. Which key do you propose we use?
There was a problem hiding this comment.
Hi @EnricoMi , in latest commit i added a environment release for this step - could you please create this environment and secret associated to it?
It would be best to have enabled Deployment branches and tags with Selected branches and tags as this job would be triggered only from v* tags pattern
There was a problem hiding this comment.
shouldn't we use a private key owned by GR here, not my personal one? Same with the OSSRH login, that should be a general GR login used by all packages that deploy to maven, not a personal access.
|
FYI rebase & resolving config is done |
|
i just realised during resolving conflict i lost few changes that should be here, will move this PR as draft until i get them back |
Previous PR for the same topic was #200, but closed as it required major changes and approach which is shown in this PR
What type of PR is this?
This is an improvement PR with the goal of enabling spark-extension release using GitHub workflows
What this PR does / why we need it:
The goal of this task is to move the release process to GitHub workflow from current scripts that are run manually.
The current release process is documented in [RELEASE.md](https://github.com/G-Research/spark-extension/blob/master/RELEASE.md/.
Due to its complexity, we reached out to one of the maintainers Enrico who approved this idea of moving
release.shto a github workflow for it's transparent and better usage.Acceptance criteria / Notes for the reviewer:
Most of the comments and testing were done forked repo
Part of maturity matrix: https://github.com/G-Research/oss-portfolio-maturity/issues/32