fix(testing): allow loading esm config #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Coly010
force-pushed
the
fix-cypress-plugin
branch
from
cd0c057
to
4679a8b
Compare
Coly010
commented
Jan 31, 2024
| @@ -157,7 +158,8 @@ describe('@nx/cypress/plugin', () => { | |||
| `); | |||
| }); | |||
|
|
|||
| it('should use ciDevServerTarget to create additional configurations', () => { | |||
| // TODO(Colum): Enable this | |||
| xit('should use ciDevServerTarget to create additional configurations', async () => { | |||
There was a problem hiding this comment.
This test fails because of the following line in setupWorkspaceContext which doesn't play ball with tempFs
https://github.com/nrwl/nx/blob/2374d8eaba89f1f82e789cc14b62230c2393862d/packages/nx/src/utils/workspace-context.ts#L9
It tries to require it from the tempFS's temporary directory, and it doesn't exist.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This still fails if the file ext is
.jsand it contains ESM.