Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for native PHP8 View attributes #2326

Merged
merged 1 commit into from Nov 23, 2021

Conversation

W0rma
Copy link
Contributor

@W0rma W0rma commented Aug 19, 2021

Related to #2301

composer.json Show resolved Hide resolved
@W0rma W0rma marked this pull request as ready for review August 19, 2021 13:04
@W0rma W0rma force-pushed the view-attribute branch 3 times, most recently from 91a5713 to 1f3ba1b Compare October 12, 2021 14:32
@W0rma
Copy link
Contributor Author

W0rma commented Oct 28, 2021

@goetas Please let me know how I can help to move this PR forward.

I will finish #2327 as soon as this PR got merged

Copy link
Contributor

@deluxetom deluxetom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work @W0rma, thank you!

@goetas goetas merged commit bf7ea87 into FriendsOfSymfony:3.x Nov 23, 2021
@goetas goetas added this to the 3.2 milestone Nov 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants