Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added simple task crud tutorial #1545

Open
wants to merge 3 commits into
base: 3.x
Choose a base branch
from

Conversation

cve
Copy link

@cve cve commented Jul 27, 2016

I'm added simple task crud tutorial to documentation which shows how to handle requests with Forms.

@lsmith77
Copy link
Member

I think this is a good idea to have.

@xabbuh what do you think?

Resources/doc/task-crud-tutorial.rst Outdated Show resolved Hide resolved
Resources/doc/task-crud-tutorial.rst Outdated Show resolved Hide resolved
Resources/doc/task-crud-tutorial.rst Outdated Show resolved Hide resolved
Resources/doc/task-crud-tutorial.rst Outdated Show resolved Hide resolved
* Get id
*
* @return int
*/
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would omit all the docblock comments. They imo do not add much value.

Resources/doc/task-crud-tutorial.rst Outdated Show resolved Hide resolved
Resources/doc/task-crud-tutorial.rst Outdated Show resolved Hide resolved
Resources/doc/task-crud-tutorial.rst Outdated Show resolved Hide resolved
Resources/doc/task-crud-tutorial.rst Outdated Show resolved Hide resolved
Resources/doc/task-crud-tutorial.rst Outdated Show resolved Hide resolved
@xabbuh
Copy link
Member

xabbuh commented Oct 12, 2016

In general this looks good so far. I have just left some minor comments.

On a general note: I would be in favour to reword the chapter to not be in the first person perspective. That would be more inline with the rest of the documentation.

@GuilhemN GuilhemN closed this Jun 15, 2020
@GuilhemN GuilhemN reopened this Jun 15, 2020
@GuilhemN GuilhemN changed the base branch from master to 3.x June 15, 2020 21:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants