Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Basic couchdb support #397

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

gaubej
Copy link

@gaubej gaubej commented Feb 21, 2016

For my project, I use CouchDB database. So I had to work with FOSOAuthBundle and CouchDB.
I've use MongoDB Document and just edit existant couchdb model.

I still have some problem to verify client credentials using FindOneBy because CouchDB don't find my Id this way. So I had to search using juste secret then verify my id.

This is my first contribution so I wait for your advice and feedback.

@gaubej
Copy link
Author

gaubej commented May 4, 2017

Can I have some update about this ? This is very important if we want to use Couchdb 2.0 as database.

Copy link

@GSokol GSokol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove var_dump and die.

@@ -28,6 +28,9 @@ public function createToken()
*/
public function findTokenByToken($token)
{
$result = $this->findTokenBy(array('token' => $token));
var_dump($result);
die();
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's that? 💩

@gaubej
Copy link
Author

gaubej commented May 10, 2017

Sorry for that, I have commited corrections

@GSokol
Copy link

GSokol commented May 11, 2017

Now cool waiting for acceptance too!

@gaubej
Copy link
Author

gaubej commented Sep 28, 2017

Can this be integrate ? Can someone accept this ? Is there any problem ?

@dinamic
Copy link
Contributor

dinamic commented Feb 1, 2018

There are a few conflicts. Maybe you can rebase on top of master.

@dkarlovi should be able to get this merged.

@dkarlovi
Copy link
Contributor

@gaubej is this obsoleted by #524? If so, please close it and we can work on this there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants