Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Bugfix when baseurl is missing or empty in json" #374

Merged
merged 1 commit into from Jan 13, 2020

Conversation

tobias-93
Copy link
Collaborator

Reverts #371 as the baseurl is not the correct location for the host.

@tobias-93 tobias-93 merged commit a826e03 into master Jan 13, 2020
@Ousret
Copy link
Contributor

Ousret commented Jan 13, 2020

Hi @tobias-93

So we should do it for host and port field instead ?

@tobias-93
Copy link
Collaborator Author

Hi @Ousret,

I think that would be best, but I'd like to test it first before merging it to prevent issues like the ones with the previous solution.
I'd like to confine the discussion to #375.

@tobias-93 tobias-93 deleted the revert-371-patch-1 branch December 15, 2023 22:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants