Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for symfony v5 #364

Closed
wants to merge 1 commit into from
Closed

Conversation

ad3n
Copy link

@ad3n ad3n commented Nov 21, 2019

add support for symfony v5

add support for symfony v5
@shinyvision
Copy link
Contributor

I think FOS\JsRoutingBundle\Command\RouterDebugExposedCommand:execute should return an exit code as seen in the travis jobs and apparently the PHPUnit framework expects return type declarations now.

I would fix these, but I don't think it's possible to add anything to your PR. Really interested in having things up to date with Symfony 5 though :D

@kl3sk kl3sk mentioned this pull request Nov 26, 2019
@Cryde
Copy link

Cryde commented Nov 27, 2019

It's would be nice to have this bundle in SF5 🙏

@kl3sk
Copy link

kl3sk commented Nov 28, 2019

@rachel-fizz maybe do your own PR ?

@shinyvision
Copy link
Contributor

@rachel-fizz maybe do your own PR ?

Sure! I'll take a look later today. Was hoping on @ad3n to make some modifications in the past couple of days :p

@kl3sk
Copy link

kl3sk commented Nov 28, 2019

If you know how to, do your own. It will be way faster because of your activity 😉.
And all the community will thank you 👐

@shinyvision
Copy link
Contributor

To quote my fellow Dutch people: Hoppa!

@tobias-93
Copy link
Collaborator

Closed in favour of #366

@tobias-93 tobias-93 closed this Dec 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants