Inform to expose routes annotation before run dump #317
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Maybe I'm wrong but Using Webpack Encore I was trying to use FOSJsRoutingBundle for the first time. After runned dump command I don't have any routes in fos_js_routes.json , I had to expose them in annotations and run again the command. So we can inform people and put a link to the expose route part
stof
requested changes
Mar 22, 2018
| @@ -24,6 +24,10 @@ In applications not using webpack add these two lines in your layout: | |||
| If you are using webpack and Encore to package your assets you will need to use the dump command | |||
| and export your routes to json, this command will create a json file into the ``web/js`` folder: | |||
|
|
|||
| .. note:: | |||
|
|
|||
| If you are using annotations for routing you have to expose your routes before running this command | |||
There was a problem hiding this comment.
this is not limited to annotations. Configuring which routes are exposed should always be done before dumping (as the dump will only include the exposed routes).
| @@ -24,6 +24,10 @@ In applications not using webpack add these two lines in your layout: | |||
| If you are using webpack and Encore to package your assets you will need to use the dump command | |||
| and export your routes to json, this command will create a json file into the ``web/js`` folder: | |||
|
|
|||
| .. note:: | |||
There was a problem hiding this comment.
This note is in the wrong place, as the previous paragraph expects to be followed by the code block.
There was a problem hiding this comment.
If I understand we just have to change section part of documention and put expose section on top before the dump section. What do you think ?
There was a problem hiding this comment.
Yes, that would be a nice solution.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Maybe I'm wrong but Using Webpack Encore I was trying to use FOSJsRoutingBundle for the first time. After runned dump command I don't have any routes in fos_js_routes.json , I had to expose them in annotations and run again the command. So we can inform people and put a link to the expose route part