New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Restored pagerfanta/pagerfanta dependency #1912
Conversation
Since adapters are needed for the functionality they should be installed automatically otherwise exceptions are thrown. Feel free to close the PR if that was intentional and we have to specify the adapters we need from now on manually. This should be mentioned in the documentation and in the CHANGELOG though.
Alternatively we could restore the |
Either go back to requiring the mono-package or do nothing. Making these packages hard requirements also means their transient dependencies become hard requirements, meaning all of The mono-package doesn't require anything but So it's really a matter of trade-offs I guess, install a mono-package with no guarantee that its transient dependencies are met or improve the documentation and runtime checks to inform users how to handle dependencies for optional features (since this package doesn't require |
This is also a possibility. I personally very much prefer to reduce the amount of dependencies when possible and from my understanding these three adapters are the only ones that needed. So why not get rid of other 5? This won't be a breaking change.
|
Oh yes valid point by @mbabker. Then mono-package is the way to go and a split in the next major. |
Thanks @Arconian |
Since adapters are needed for the functionality they should be installed automatically otherwise exceptions are thrown.
Feel free to close the PR if that was intentional and we have to specify the adapters we need from now on manually. This should be mentioned in the documentation and in the CHANGELOG though.
Fixes #1911.