Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pagerfanta v4.x compatibility #1908

Merged
merged 2 commits into from Jun 22, 2023
Merged

Pagerfanta v4.x compatibility #1908

merged 2 commits into from Jun 22, 2023

Conversation

evertharmeling
Copy link
Contributor

Should fix #1907

@XWB
Copy link
Member

XWB commented May 22, 2023

Tests are failing, can you fix them?

@evertharmeling
Copy link
Contributor Author

Since the getQueryBuilder method is deprecated (per Pagerfanta/doctrine-mongodb-odm-adapter:v3.0 and per Pagerfanta/doctrine-phpcr-odm-adapter:v3.0). It's probably safe to remove the assertion which fixes the testsuite.

@XWB XWB merged commit f44abba into FriendsOfSymfony:master Jun 22, 2023
19 checks passed
@XWB
Copy link
Member

XWB commented Jun 22, 2023

Thanks

@evertharmeling
Copy link
Contributor Author

@XWB is it possible to schedule a new release of the bundle? Thanks in advance!

@bobvandevijver
Copy link
Contributor

@XWB We're also looking for this release, can you create one? Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@XWB XWB XWB approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Pagerfanta v4.x compatibility
3 participants
@evertharmeling @XWB @bobvandevijver