Remove count from async persister #1905
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
— result from insertPage not used anywhere, and it is resulted in useless and expensive query to database.
oleg-andreyev
commented
Apr 6, 2023
| $messageBus = $this->createMock(MessageBusInterface::class); | ||
| $sut = new AsyncPagerPersister($pagerPersisterRegistry, $pagerProviderRegistry, $messageBus); | ||
|
|
||
| $sut->insertPage(1, [ |
There was a problem hiding this comment.
funny fact this should have been assert result of insertPage but it's no doing it.
Do you know why it is useless? Do you mean the count result is inaccurate? |
Based on usage in |
XWB
approved these changes
May 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Async Persister is returning useless count that is not used anywhere but to calculate it, we are making an expensive COUNT() query.