Merge pull request #1494 from Labstep/testing/improve-paginator-coverage

Improve testing coverage for src/Paginator/
FriendsOfSymfony · Jan 28, 2019 · 61ff1f9 · 61ff1f9
2 parents 6a01018 + 03bf188
commit 61ff1f9
Show file tree

Hide file tree

Showing 4 changed files with 125 additions and 11 deletions.
diff --git a/tests/Unit/Paginator/HybridPaginatorAdapterTest.php b/tests/Unit/Paginator/HybridPaginatorAdapterTest.php
@@ -0,0 +1,49 @@
+<?php
+
+/*
+ * This file is part of the FOSElasticaBundle package.
+ *
+ * (c) FriendsOfSymfony <http://friendsofsymfony.github.com/>
+ *
+ * For the full copyright and license information, please view the LICENSE
+ * file that was distributed with this source code.
+ */
+
+namespace FOS\ElasticaBundle\Tests\Unit\Event;
+
+use FOS\ElasticaBundle\Paginator\HybridPaginatorAdapter;
+use Elastica\Query;
+use Elastica\SearchableInterface;
+use FOS\ElasticaBundle\Transformer\ElasticaToModelTransformerInterface;
+use FOS\ElasticaBundle\Tests\Unit\UnitTestHelper;
+
+class HybridPaginatorAdapterTest extends UnitTestHelper
+{
+    protected function mockHybridPaginatorAdapter($args)
+    {
+        $mock = $this
+            ->getMockBuilder(HybridPaginatorAdapter::class)
+            ->setConstructorArgs($args)
+            ->setMethods(['getElasticaResults'])
+            ->getMock();
+
+        $resultSet = $this->mockResultSet();
+
+        $mock
+            ->expects($this->exactly(1))
+            ->method('getElasticaResults')
+            ->willReturn($resultSet);
+
+        return $mock;
+    }
+
+    public function testGetResults()
+    {
+        $searchable = $this->mockSearchable();
+        $query = new Query();
+        $transformer = $this->mockElasticaToModelTransformer();
+
+        $adapter = $this->mockHybridPaginatorAdapter([$searchable, $query, $transformer]);
+        $adapter->getResults(0, 0);
+    }
+}
diff --git a/tests/Unit/Paginator/HybridPartialResultsTest.php b/tests/Unit/Paginator/HybridPartialResultsTest.php
@@ -0,0 +1,45 @@
+<?php
+
+/*
+ * This file is part of the FOSElasticaBundle package.
+ *
+ * (c) FriendsOfSymfony <http://friendsofsymfony.github.com/>
+ *
+ * For the full copyright and license information, please view the LICENSE
+ * file that was distributed with this source code.
+ */
+
+namespace FOS\ElasticaBundle\Tests\Unit\Event;
+
+use FOS\ElasticaBundle\Paginator\HybridPartialResults;
+use Elastica\ResultSet;
+use FOS\ElasticaBundle\Tests\Unit\UnitTestHelper;
+
+class HybridPartialResultsTest extends UnitTestHelper
+{
+    protected function mockResultSet()
+    {
+        $mock = $this
+            ->getMockBuilder(ResultSet::class)
+            ->disableOriginalConstructor()
+            ->getMock();
+
+        $mock
+            ->expects($this->exactly(1))
+            ->method('getResults')
+            ->willReturn([]);
+
+        return $mock;
+    }
+
+    public function testToArray()
+    {
+        $transformer = $this->mockElasticaToModelTransformer();
+
+        $resultSet = $this->mockResultSet();
+
+        $results = new HybridPartialResults($resultSet, $transformer);
+
+        $results->toArray();
+    }
+}
diff --git a/tests/Unit/Paginator/RawPaginatorAdapterTest.php b/tests/Unit/Paginator/RawPaginatorAdapterTest.php
@@ -16,11 +16,11 @@
 use Elastica\ResultSet;
 use Elastica\SearchableInterface;
 use InvalidArgumentException;
-use PHPUnit\Framework\TestCase;
+use FOS\ElasticaBundle\Tests\Unit\UnitTestHelper;
 
-class RawPaginatorAdapterTest extends TestCase
+class RawPaginatorAdapterTest extends UnitTestHelper
 {
-    private function mockResultSet()
+    protected function mockResultSet()
     {
         $methods = ['getTotalHits', 'getAggregations', 'getSuggests', 'getMaxScore'];
         $mock = $this
@@ -31,14 +31,6 @@ private function mockResultSet()
         return $mock;
     }
 
-    private function mockSearchable()
-    {
-        $mock = $this
-            ->getMockBuilder(SearchableInterface::class)
-            ->getMock();
-        return $mock;
-    }
-
     private function createAdapterWithSearch($methodName, $value)
     {
         $resultSet = $this->mockResultSet();

diff --git a/tests/Unit/UnitTestHelper.php b/tests/Unit/UnitTestHelper.php
@@ -11,6 +11,9 @@
 
 namespace FOS\ElasticaBundle\Tests\Unit;
 
+use FOS\ElasticaBundle\Transformer\ElasticaToModelTransformerInterface;
+use Elastica\SearchableInterface;
+use Elastica\ResultSet;
 use PHPUnit\Framework\TestCase;
 
 class UnitTestHelper extends TestCase
@@ -29,4 +32,29 @@ protected function getProtectedProperty($object, string $property)
 
         return $reflectionProperty->getValue($object);
     }
+
+    protected function mockElasticaToModelTransformer()
+    {
+        $mock = $this
+            ->getMockBuilder(ElasticaToModelTransformerInterface::class)
+            ->getMock();
+        return $mock;
+    }
+
+    protected function mockSearchable()
+    {
+        $mock = $this
+            ->getMockBuilder(SearchableInterface::class)
+            ->getMock();
+        return $mock;
+    }
+
+    protected function mockResultSet()
+    {
+        $mock = $this
+            ->getMockBuilder(ResultSet::class)
+            ->disableOriginalConstructor()
+            ->getMock();
+        return $mock;
+    }
 }