Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FullyQualifiedStrictTypesFixer - space bug #3924

Merged
merged 1 commit into from Aug 10, 2018
Merged

FullyQualifiedStrictTypesFixer - space bug #3924

merged 1 commit into from Aug 10, 2018

Conversation

dmvdbrugge
Copy link
Contributor

@dmvdbrugge dmvdbrugge commented Jul 16, 2018 •
edited

This fixes #3861

@dmvdbrugge dmvdbrugge force-pushed the 3861-fully_qualified_strict_types-space-bug branch from 6873718 to ee8f3e0 Compare July 16, 2018 16:12
@dmvdbrugge dmvdbrugge mentioned this pull request Jul 23, 2018
Closed
@SpacePossum SpacePossum added this to the 2.12.3 milestone Jul 30, 2018
@dmvdbrugge
Fix ArgumentsAnalyzer
51d1199 
Started with failing tests (which now pass obviously).
@dmvdbrugge dmvdbrugge force-pushed the 3861-fully_qualified_strict_types-space-bug branch from ee8f3e0 to 51d1199 Compare July 30, 2018 19:13
@dmvdbrugge dmvdbrugge mentioned this pull request Aug 9, 2018
Closed
@keradus keradus added the RTM Ready To Merge label Aug 9, 2018
@keradus keradus removed the RTM Ready To Merge label Aug 10, 2018
@keradus
Copy link
Member

keradus commented Aug 10, 2018

Thank you @dmvdbrugge.

@keradus keradus merged commit 51d1199 into PHP-CS-Fixer:2.12 Aug 10, 2018
keradus added a commit that referenced this pull request Aug 10, 2018
@keradus
bug #3924 FullyQualifiedStrictTypesFixer - space bug (dmvdbrugge)
b64651d 
This PR was merged into the 2.12 branch.

Discussion
----------

FullyQualifiedStrictTypesFixer - space bug

This fixes #3861

Commits
-------

51d1199 Fix ArgumentsAnalyzer
@dmvdbrugge dmvdbrugge deleted the 3861-fully_qualified_strict_types-space-bug branch August 10, 2018 10:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@keradus keradus keradus approved these changes

@ntzm ntzm ntzm approved these changes

@SpacePossum SpacePossum SpacePossum approved these changes

Assignees
No one assigned
Labels
kind/bug
Projects
None yet
Milestone
2.12.3
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@dmvdbrugge @keradus @ntzm @SpacePossum