FullyQualifiedStrictTypesFixer - NoSuperfluousPhpdocTagsFixer - adjust priority #3912
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SpacePossum
reviewed
Jul 30, 2018
| public function getPriority() | ||
| { | ||
| // should run after PhpdocToReturnTypeFixer | ||
| // should run before NoSuperfluousPhpdocTagsFixer |
There was a problem hiding this comment.
the added test shows the prio issue for NoSuperfluousPhpdocTagsFixer, but not for PhpdocToReturnTypeFixer, is the priority test missing or is the comment a bit off?
There was a problem hiding this comment.
The priority test already exists because the priority was already there (and adhered to).
There was a problem hiding this comment.
ah check, missed that one 👍
SpacePossum
approved these changes
Jul 30, 2018
dmvdbrugge
force-pushed
the
fully_qualified_strict_types-no_superfluous_phpdoc_tags-priority
branch
from
b69bc6c
to
fa17194
Compare
keradus
changed the title
|
Thank you @dmvdbrugge. |
dmvdbrugge
deleted the
fully_qualified_strict_types-no_superfluous_phpdoc_tags-priority
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #3850