Add install/update instructions for PHIVE to the README #3848
Conversation
README.rst
Outdated
|
|
||
| .. code-block:: bash | ||
|
|
||
| $ phive install php-cs-fixer # use `--global` for global install, not recommended |
There was a problem hiding this comment.
I would drop , not recommended. It's opinionated, and even while I agree with it, we don't put that for other ways of installation, don't we ?
Here, i brings the confusion that installing sth with PHIVE globally is not recommended, it's not true.
We simply don't recommend to install dev-tools globally (as their versions depends on project), regardless which way of installation was chosen
There was a problem hiding this comment.
so maybe just drop the comment completely?
| @@ -131,6 +131,15 @@ protected function execute(InputInterface $input, OutputInterface $output) | |||
|
|
|||
| $ brew install php-cs-fixer | |||
|
|
|||
| Locally (PHIVE) | |||
| ~~~~~~~~~~~~~~~~~~~ | |||
There was a problem hiding this comment.
Why so long? Other underline-ish lines are with the length of the text above.
There was a problem hiding this comment.
I'll admit, the lengthy ~ is a result of copying another (sub)header, I'll update soon, thanks for the sharp review 👍 :)
SpacePossum
changed the title
| @@ -124,6 +133,13 @@ You can update ``php-cs-fixer`` through this command: | |||
|
|
|||
| $ brew upgrade php-cs-fixer | |||
|
|
|||
| Locally (PHIVE) | |||
| ~~~~~~~~~~~~~~~~~~~ | |||
There was a problem hiding this comment.
No so fast, this one is also too long ;)
Oh, already merged :(
There was a problem hiding this comment.
oh no, I really really really thought I had this covered, f**k me, this is a lesson learned on my "I wished wasn't needed "-list :(
aaarrggh I'm sorry man, you called me out on it before and still I messed it up, f**k me :(
There was a problem hiding this comment.
no worry. instead of fixing that, let us run rst / md linters on CI :D
closes #3838