Fix type error when electricity_collection is null #49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Billogram recently updated the api in a silent upgrade. The `electricity_collection` can now return null which made the `CollectionForElectricityInvoices::createFromArray` crash. This commit is not a complete fix but solves the current crash caused by Billogram returning null values. According to the Billogram documentation `electricity_collection` is deprecated and should no longer be defined at the billogram level, but instead defined at item level.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Billogram recently updated the api in a silent upgrade. The
electricity_collectioncan now return null which made theCollectionForElectricityInvoices::createFromArraycrash. This commit is not a complete fix but solves the current crash caused by Billogram returning null values.According to the Billogram documentation
electricity_collectionis deprecated and should no longer be defined at the billogram level, but instead defined at item level.