Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/http response code #6355

Open
wants to merge 17 commits into
base: edge
Choose a base branch
from

Conversation

ColonelMoutarde
Copy link
Contributor

Changes proposed in this pull request:

  • http code is now replace by constant

Pull request checklist:

  • clear commit messages
  • code manually tested

@Alkarex
Copy link
Member

Alkarex commented Apr 20, 2024

Plenty of dead code there. In think a short subset could potentially be done after we update the requirements to PHP 8.1+ with enum https://php.net/language.types.enumerations

@math-GH math-GH added this to the 1.25.0 milestone May 7, 2024
@ColonelMoutarde
Copy link
Contributor Author

Plenty of dead code there. In think a short subset could potentially be done after we update the requirements to PHP 8.1+ with enum https://php.net/language.types.enumerations

If we follow the roadmap, it won't be for another 2 years... that's a long time, and a small refacto at that point will be easy.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants