Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

set X-Frame-Options #6302

Draft
wants to merge 3 commits into
base: edge
Choose a base branch
from
Draft

set X-Frame-Options #6302

wants to merge 3 commits into from
+4 −0

Conversation

math-GH
Copy link
Contributor

@math-GH math-GH commented Apr 14, 2024

@math-GH math-GH added this to the 1.24.0 milestone Apr 14, 2024
@Alkarex
Copy link
Member

Alkarex commented Apr 14, 2024

This header seems obsolete

@Alkarex Alkarex modified the milestones: 1.24.0, 1.25.0 Apr 15, 2024
@math-GH
Copy link
Contributor Author

math-GH commented Apr 15, 2024

This header seems obsolete

As far as I understand it is obsolete if [frame-ancestors](https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/Content-Security-Policy/frame-ancestors) is used.

Do you prefer to use it instead of the X-Frame-Options?

@Frenzie
Copy link
Member

Frenzie commented Apr 15, 2024

Yes, frame-ancestors is to be preferred afaict.

@math-GH math-GH marked this pull request as draft May 23, 2024 19:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Security 🛡️
Projects
None yet
Milestone
1.25.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@math-GH @Alkarex @Frenzie