Reading view: action icons position #6297
Open
+285
−29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM. Thanks for the change! |
|
Tests failing |
2 tasks
4 tasks
Alkarex
reviewed
Jun 5, 2024
| @@ -123,6 +123,7 @@ public function readingAction(): void { | |||
| FreshRSS_Context::userConf()->show_tags_max = Minz_Request::paramInt('show_tags_max'); | |||
| FreshRSS_Context::userConf()->show_author_date = Minz_Request::paramString('show_author_date') ?: '0'; | |||
| FreshRSS_Context::userConf()->show_feed_name = Minz_Request::paramString('show_feed_name') ?: 't'; | |||
| FreshRSS_Context::userConf()->show_articleicons = Minz_Request::paramString('show_articleicons') ?: 't'; | |||
Alkarex
reviewed
Jun 5, 2024
Alkarex
reviewed
Jun 5, 2024
Alkarex
reviewed
Jun 5, 2024
Comment on lines
+188
to
+189
| 'above_title' => 'Above title', // TODO | ||
| 'with_authors' => 'In authors and date row', // TODO |
There was a problem hiding this comment.
Suggested change
| 'above_title' => 'Above title', // TODO | |
| 'with_authors' => 'In authors and date row', // TODO | |
| 'above_title' => 'Above title', | |
| 'with_authors' => 'In authors and date row', |
Alkarex
reviewed
Jun 5, 2024
Alkarex
reviewed
Jun 10, 2024
Comment on lines
+187
to
+189
| '_' => 'Article icons position<br /><small>(Reading view only)</small>', // TODO | ||
| 'above_title' => 'Above title', // TODO | ||
| 'with_authors' => 'In authors and date row', // TODO |
There was a problem hiding this comment.
Suggested change
| '_' => 'Article icons position<br /><small>(Reading view only)</small>', // TODO | |
| 'above_title' => 'Above title', // TODO | |
| 'with_authors' => 'In authors and date row', // TODO | |
| '_' => 'Position des icônes d'article<br /><small>(Vue lecture seulement)</small>', | |
| 'above_title' => 'Au dessus du titre', | |
| 'with_authors' => 'Sur la ligne auteur et date', |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
inspired by #6261 from @joshka
(default): above title
in authors and date row
top line article icons configs respected
How to test the feature manually:
reading, sectionArticles: header/footerPull request checklist: