-
-
Notifications
You must be signed in to change notification settings - Fork 776
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve performance #5835 #6291
base: edge
Are you sure you want to change the base?
Conversation
A timeout of 0 is meaningless. ;-) That's equivalent to removing the entire asBatch boolean and related functionality. The batching is for performance reasons. See #2199. |
0.1s would be better than 1s or 0s? |
When the |
Ah right, now I see that it was to address #5835 |
That sounds a bit suspect. That means that clicking 10 icons in a row isn't batched while pressing j or k 10 times in a row is. (Which is indeed the case.) It would seem that either the former should be too or the latter shouldn't either. |
Closes #5835
Changes proposed in this pull request:
How to test the feature manually:
Pull request checklist: