Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Empty title guid or first words #6240

Merged
merged 22 commits into from
Jun 5, 2024

Conversation

math-GH
Copy link
Contributor

@math-GH math-GH commented Mar 27, 2024

Closes #6218

If a feed has no title then the GUID/URL is shown (example feed: https://mastodon.social/tags/FreshRSS.rss):
grafik

After:
show the first 75 characters. (config via configs, if necessary)
grafik

Pull request checklist:

  • clear commit messages
  • code manually tested

@math-GH math-GH added View UX User experience labels Mar 27, 2024
@math-GH math-GH added this to the 1.24.0 milestone Mar 27, 2024
@Alkarex Alkarex modified the milestones: 1.24.0, 1.25.0 Mar 27, 2024
@Alkarex
Copy link
Member

Alkarex commented Mar 27, 2024

I would rather avoid a new option and just have one behaviour, which works well.
First we need to distinguish the Web UI and the API.
In the Web UI, I think it would be fine to:

  • Show the title if not blank
  • Otherwise show the first words if not blank
  • Otherwise show the GUID

@Frenzie
Copy link
Member

Frenzie commented Mar 27, 2024

I would rather avoid a new option and just have one behaviour, which works well.

Though imo the current behavior works better… well, besides on such a Mastodon feed with meaningless ids.

@math-GH
Copy link
Contributor Author

math-GH commented Mar 27, 2024

Now it is simplified

@thecptrgod
Copy link

That's a good idea for what the interface should look like. (Sorry this is late...been slammed all week.)

@Frenzie
Copy link
Member

Frenzie commented Mar 29, 2024

Though imo the current behavior works better… well, besides on such a Mastodon feed with meaningless ids.

On second thought the overlap of URLs looking nice combined with missing titles is probably minuscule.

app/Models/Entry.php Outdated Show resolved Hide resolved
constants.php Outdated Show resolved Hide resolved
app/Models/Entry.php Outdated Show resolved Hide resolved
@Alkarex Alkarex merged commit fec9e53 into FreshRSS:edge Jun 5, 2024
2 checks passed
@math-GH math-GH deleted the empty-title-guid-or-firstWords branch June 5, 2024 20:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
UX User experience View
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feed items with no title
4 participants