Counted all favorites

[math-GH]

IMHO the total number of favorite articles is useless. There is no similar thing that shows up the absolut number of articles. Furthermore the number cannot be styled.

This PR deletes the number. It reduces 1 SQL query in each page load of a view.

Before:

After:

[Frenzie]

I don't think it's comparable to the total number of articles. The total number of articles is a meaningless consequence of a few settings while the number of favorites is something that was quite purposefully caused by the user. But I don't mean that as an argument to keep that number, or at the very least not in that location.

[math-GH]

I don't think it's comparable to the total number of articles. The total number of articles is a meaningless consequence of a few settings while the number of favorites is something that was quite purposefully caused by the user. But I don't mean that as an argument to keep that number, or at the very least not in that location.

Thanks for your opinion. Nice argumentation, that could be similar to the labels, isn't it?

[math-GH]

It became a little refactoring.

countUnreadReadFavorites() is splitted now into countUnreadFavorites() and countFavorites() (countFavorites() is only used by user-info.php). The return values are now simple int instead of arrays.

[Frenzie]

Thanks for your opinion. Nice argumentation, that could be similar to the labels, isn't it?

Yes, I would agree that conceptually favorite is a special label.