-
-
Notifications
You must be signed in to change notification settings - Fork 776
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
General layout improvement: Top level navigation + structure #6047
base: edge
Are you sure you want to change the base?
Conversation
I like the fixed bar at the top 👍🏻 I am more neutral about the left bar. But it is nice with an update 🙂 The improvements of the mobile view are what I am most looking forward to. A couple of notes, which you probably already have spotted:
|
The complexity with the flush is that it depends on some buffering / size of content, at more than one place in the pipeline all the way to the screen of the user.
|
app/layout/header.phtml
Outdated
$keepAllURLParameters = true; | ||
$href = ''; | ||
if (!in_array(Minz_Request::actionName(), ['normal', 'global', 'reader'])) { | ||
$keepAllURLParameters = false; | ||
|
||
} | ||
|
||
/** @var FreshRSS_ReadingMode $mode */ | ||
foreach ($readingModes as $mode) { | ||
if ($keepAllURLParameters) { | ||
// keep all URL parameters if the current page is a view | ||
$href = Minz_Url::display($mode->getUrlParams()); | ||
} else { | ||
echo FreshRSS_Context::systemConf()->logo_html; | ||
$params = $mode->getUrlParams(); | ||
$href = Minz_Url::display(['c' => $params['c'], 'a' => $params['a']]); | ||
} | ||
?> | ||
|
||
<a class="<?= $mode->getId() ?> btn <?php if ($mode->isActive()) { echo 'active'; } ?>" title="<?= | ||
$mode->getTitle() ?>" href="<?= $href ?>"> | ||
<?= $mode->getName() ?> | ||
</a> | ||
<?php | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it is not the smartest solution to solve #6162 but it works so far.
@Alkarex This feedback was very valuable. It gave me the kick to finde a better solution as |
The first draft was presented in #5966. This is now the implementation.
close #4224
This PR is still in draft but I am happy about each comment or feedback
known issues
(more screenshots + description will follow)
Out of scope
(not so important, discussion needed, PR could follow):