improve phpdoc #5962
Open
improve phpdoc #5962
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Alkarex
reviewed
Dec 22, 2023
ColonelMoutarde
commented
Dec 22, 2023
Alkarex
reviewed
Dec 29, 2023
Alkarex
added a commit
to Alkarex/FreshRSS
that referenced
this pull request
Jan 13, 2024
Take advantage of https://phpstan.org/blog/bring-your-exceptions-under-control Minimum changes to pass `tooWideThrowType` and `implicitThrows`. Revert some mistakes from: FreshRSS#5504 Preparation needed before new PRs of the same type: FreshRSS#5962 Fix several wrong PHPDocs and catches: > Method ... has ...Exception in PHPDoc @throws tag but it's not thrown. > Dead catch - ...Exception is never thrown in the try block.
|
Let's be a bit more methodic with #6037 first |
Alkarex
added a commit
that referenced
this pull request
Jan 15, 2024
Take advantage of https://phpstan.org/blog/bring-your-exceptions-under-control Minimum changes to pass `tooWideThrowType` and `implicitThrows`. Revert some mistakes from: #5504 Preparation needed before new PRs of the same type: #5962 Fix several wrong PHPDocs and catches: > Method ... has ...Exception in PHPDoc @throws tag but it's not thrown. > Dead catch - ...Exception is never thrown in the try block.
Alkarex
reviewed
Jan 17, 2024
Alkarex
reviewed
Jan 17, 2024
|
Adding all the |
ColonelMoutarde
force-pushed
the
chore/improve-phpdoc
branch
from
51dd305
to
421d730
Compare
Co-authored-by: Alexandre Alapetite <alexandre@alapetite.fr>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this pull request:
Pull request checklist: