Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Japanese to font-family #5671

Open
wants to merge 3 commits into
base: edge
Choose a base branch
from
Open

Conversation

superuser7777
Copy link

Please consider changing the CSS as shown below.
This modification improves display readability for Japanese people.

Add
"Osaka",

Change before
font-family: "OpenSans", "Cantarell", "Helvetica", "Arial", "PingFang SC", "Microsoft YaHei", sans-serif;

After change
font-family: "OpenSans", "Cantarell", "Helvetica", "Arial", "Osaka", "PingFang SC", "Microsoft YaHei", sans-serif;

The Chinese fonts such as "PingFang SC" and "Microsoft YaHei" can be displayed like Japanese, but the kanji are greatly broken down, making them difficult for Japanese people to read.

--
Thank you for the great software!
I've migrated all my RSS readers to FreshRSS!

@Alkarex Alkarex added this to the 1.22.0 milestone Sep 25, 2023
@Alkarex Alkarex added I18n 🌍 Translations Theme labels Sep 25, 2023
@Alkarex
Copy link
Member

Alkarex commented Sep 25, 2023

We should probably update all the themes, which have overridden the base font definition, e.g.:

font-family: "OpenSans", "Cantarell", "Helvetica", "Arial", "PingFang SC", "Microsoft YaHei", sans-serif;

Edit: Done 3864634

@Alkarex
Copy link
Member

Alkarex commented Sep 25, 2023

Related to #1541

@hoilc if you are around, do you have any comment? For instance a negative consequence, we might have overlooked?

@Alkarex Alkarex changed the title Update base.css 783-contributing-file #5670 Add Japanese to font-family Sep 25, 2023
@Alkarex
Copy link
Member

Alkarex commented Sep 25, 2023

I am wondering whether adding (only) "Osaka" is the most appropriate fix. It seems to be only for Apple. Isn't e.g. "MS Gothic" more common?

@Alkarex
Copy link
Member

Alkarex commented Sep 25, 2023

Note for later: we should add a way to tweak font parameters independently of the default settings proposed by the themes (we might have an issue somewhere already)

Copy link
Contributor

@math-GH math-GH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is very nice to know that FreshRSS is used in Japan too :)

Please support us here with screenshots "before" and "after" the change.

Please find another default font families that is installed on Windows by default. Linux would be fine too.

@Alkarex Alkarex modified the milestones: 1.22.0, 1.23.0 Oct 8, 2023
@math-GH
Copy link
Contributor

math-GH commented Oct 15, 2023

the conflicted files can be deleted to solve the conflict

@Alkarex
Copy link
Member

Alkarex commented Nov 21, 2023

@superuser7777 Your feedback would be welcome in #5895 , for instance related to font selection and calendar selection (which calendar system do you use?)

@Alkarex Alkarex modified the milestones: 1.23.0, 1.24.0 Dec 20, 2023
@Alkarex Alkarex modified the milestones: 1.24.0, 1.25.0 Apr 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
I18n 🌍 Translations Theme
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants