Skip superfluous conversion to Date in ft-list-video

[absidue]

Skip superfluous conversion to Date in ft-list-video

Pull Request Type

• Bugfix

Description

Inside ft-list-video we create a Date object from the published timestamp number before passing it to getRelativeTimeFromDate but in that function it only gets used in some arithmetic, so gets immediately converted back into a number by JavaScript (the date variable):

FreeTube/src/renderer/helpers/utils.js

Lines 748 to 756 in b9d5778

	export function getRelativeTimeFromDate(date, hideSeconds = false, useThirtyDayMonths = true) {
	if (!date) {
	return ''
	}
	const now = new Date().getTime()
	// Convert from ms to second
	// For easier code interpretation the value is made to be positive
	let timeDiffFromNow = ((now - date) / 1000)

We also know that it will always be a number because it's typechecked just a few lines above:

FreeTube/src/renderer/components/ft-list-video/ft-list-video.js

Lines 666 to 674 in b9d5778

	} else if (typeof this.data.published === 'number' && !this.isLive) {
	this.published = this.data.published
	if (this.inHistory) {
	this.uploadedTime = new Date(this.data.published).toLocaleDateString([this.currentLocale, 'en'])
	} else {
	// Use 30 days per month, just like calculatePublishedDate
	this.uploadedTime = getRelativeTimeFromDate(new Date(this.data.published), false)
	}

TL;DR it's a number and we use it as a number, so we don't need the conversion to a Date object and back.

Testing

Open a video list e.g. the subscriptions and check that the relative published dates show up correctly.

Desktop

• OS: Windows
• OS Version: 10
• FreeTube version: b9d5778