Fix gap next to banner when Hide Side Bar Labels is enabled #5120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
absidue
requested review from
PikachuEXE,
efb4f5ff-1298-471a-8973-3d47447115dc,
ChunkyProgrammer,
jasonhenriquez and
MarmadileManteater
github-actions
bot
added
the
PR: waiting for review
|
I will note that this issue is affecting #4949 as well. If that PR is merged first, you just have to apply these changes to the mixin instead of the |
PikachuEXE
approved these changes
May 18, 2024
efb4f5ff-1298-471a-8973-3d47447115dc
approved these changes
May 19, 2024
jasonhenriquez
approved these changes
May 21, 2024
github-actions
bot
removed
the
PR: waiting for review
Merged
1 task
PikachuEXE
added a commit
to PikachuEXE/FreeTube
that referenced
this pull request
May 23, 2024
* development: Update playlist name with title (FreeTubeApp#5150) User playlists as grid (FreeTubeApp#4949) Add custom webpack loader to remove unused mimetypes from mime-db (FreeTubeApp#5148) ^ Update GH action eps1lon/actions-label-merge-conflict (FreeTubeApp#5034) Translated using Weblate (Italian) Translated using Weblate (Serbian) Translated using Weblate (Estonian) Translated using Weblate (Bulgarian) Translated using Weblate (Spanish) Translated using Weblate (Italian) Translated using Weblate (Polish) Translated using Weblate (Portuguese (Brazil)) Translated using Weblate (French) Translated using Weblate (Chinese (Traditional)) Translated using Weblate (Chinese (Simplified)) Fix gap next to banner when Hide Side Bar Labels is enabled (FreeTubeApp#5120)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix gap next to banner when Hide Side Bar Labels is enabled
Pull Request Type
Related issue
https://github.com/FreeTubeApp/FreeTube/projects/10#card-92520872
Description
This pull request makes the
ft-refresh-widgettake up the correct amount of space when theHide Side Bar Labelssetting is enabled, as it has a gap on the left side at the moment.Screenshots
Before:
After:
Testing
Hide Side Bar Labelsin theTheme SettingsRegression tests
Hide Side Bar Labelssetting is turned offDesktop
Additional context
Not sure why the CSS rules in this component are all namespaced with the
.floatingRefreshSectionclass, when Vue's scoped CSS feature already takes care of only applying it to the right component for us (seescopedattribute on the<style>tag in the template file (ft-refresh-widget.vue).