reset selected filters after search

[ankitchauhan-aka]

Pull Request Type

• Bugfix
• Feature Implementation
• Documentation
• Other

Related issue

closes #1693

Description

Testing

1. Apply filters, You must have a red border that shows filter(s) are selected
2. Then search for a term in the search box and choose any option from autosuggestion dropdown
3. After selecting autosuggested options, Filters must be reset to default options.
4. The red border from the filter icon will be removed

[PikachuEXE]

I tested with these steps and failed

• Enter something, enter search result via enter/search button
• Change filter options
• Press search button again
• Search result not updated but filter reset

[ankitchauhan-aka]

I tested with these steps and failed

• Enter something, enter search result via enter/search button
• Change filter options
• Press search button again
• Search result not updated but filter reset

@PikachuEXE I'm attaching a test video with the mentioned steps and cannot replicate the issue. Please share similar so I can fix it ASAP and the same happens in YouTube (as I feel we're taking references from there). Like even if we hit search for the same query it resets the filter.

Not sure, If we've a different requirement here.

Screen.Recording.2024-04-29.at.10.09.26.AM.mov

[PikachuEXE]

Screen.Recording.2024-04-29.at.13.33.20.mov

[ankitchauhan-aka]

@PikachuEXE I've implemented a check, not to reset filter for the same query.

[efb4f5ff-1298-471a-8973-3d47447115dc]

Filter not applied when:

1. Application starts
2. apply labels
3. enter query
4. hit search

VirtualBoxVM_E7hDKoPbOO.mp4

[ankitchauhan-aka]

Filter not applied when:

1. Application starts
2. apply labels
3. enter query
4. hit search

VirtualBoxVM_E7hDKoPbOO.mp4

Fixed.

Thanks for the review.

[PikachuEXE]

It reset filters under strange conditions (e.g. like changing filter below

Screen.Recording.2024-04-30.at.14.24.09.mov

Probably like

• Search A
• Enter B
• Try to set multiple criteria

[efb4f5ff-1298-471a-8973-3d47447115dc]

@PikachuEXE this is not a bug but intended behavior. There is how YT also behaves. In your example Time Today resets because you clicked on Type Channel. Time is based on upload date. A channel cant have a upload date.

[PikachuEXE]

OK there are several issue discovered during testing but not introduced by this PR

[efb4f5ff-1298-471a-8973-3d47447115dc]

Issue?

[github-actions]

This pull request has conflicts, please resolve those before we can evaluate the pull request.

[github-actions]

Conflicts have been resolved. A maintainer will review the pull request shortly.

[ankitchauhan-aka]

@jasonhenriquez can we get this reviewed now?

[jasonhenriquez]

Looks like the implementation was changed enough by #3975 to make the required alteration easier. Address review comments, re-validate, and you should be good.

[jasonhenriquez]

Hi @ankitchauhan-aka, are you still available to make these final alterations?

[ankitchauhan-aka]

Hi @jasonhenriquez
Yeah. I was too much occupied in my job, will do it asap

[ankitchauhan-aka]

@jasonhenriquez seems good now!

[jasonhenriquez]

In my testing, it's not actually applying the filters now - the probable issue is that the removal is processing before the results are being grabbed.

[ankitchauhan-aka]

I think that's correct behaviour. It should remove filter if search query is modified.

[jasonhenriquez]

No, I mean it's not applying the filter even the first time.

[ankitchauhan-aka]

https://www.awesomescreenshot.com/video/28282864?key=3f195c5137a0c69969519b2bdf7fe124
@jasonhenriquez Please take a look at the attached video, if you feel that some of the records do not match the time filter, So it's not related to our application logic, Even YouTube has the same results. or if your testing produces different results than mine please share a capture.

[ankitchauhan-aka]

@jasonhenriquez could you please share!

[jasonhenriquez]

Hi @ankitchauhan-aka, sorry for the delay. Just retested now; it was working the first handful of times, then just stopped applying the filter at all.

screen-recording.mp4

Before moving forward with this, I'd also like some discussion on the intended behavior. We're showing the filter as active after a search is made, until the user submits another query. That's not intuitive, as we shouldn't be showing the filter as if it's active if it isn't going to be. The main reason YT has this behavior the way it is is because changing a filter setting automatically re-submits the same search query but with the new filter. If we do want this feature, the filters should show as clear immediately after the search processes.