Remove explicitly disabling CORS. issue is fixed upstream #2623
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
issue was fixed in electron/electron#25463 it will now be disabled when with webSecurity: false
efb4f5ff-1298-471a-8973-3d47447115dc
added
the
PR: waiting for review
absidue
approved these changes
Sep 26, 2022
efb4f5ff-1298-471a-8973-3d47447115dc
approved these changes
Sep 26, 2022
ChunkyProgrammer
approved these changes
Sep 26, 2022
github-actions
bot
removed
the
PR: waiting for review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove explicitly disabling CORS. issue is fixed upstream
Pull Request Type
Please select what type of pull request this is:
Related issue
no related issue
Description
On electron
v9.0.4CORS was not disabled bywebSecurity: falseThis was fixed in electron/electron#25463
This line should no longer be needed.
Testing (for code that is not small enough to be easily understandable)
I've tested Local API and Invidious API.
tested some videos/live streams and made sure comments, description, etc were loaded.
Desktop: