Upgrade electron 14 #1763
Closed
Upgrade electron 14 #1763
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
#1640 needs to be fixed if this is added |
|
Added WIP because there are still remaining issues |
|
For #1640
|
2 tasks
efb4f5ff-1298-471a-8973-3d47447115dc
added
electron being electron
|
This will fix this #1768 (comment) Edit: I was wrong this was fixed in v13.5.1 and has been implemented in the RC. |
PikachuEXE
force-pushed
the
upgrade/electron-14
branch
from
8d46cd0
to
175139a
Compare
|
To be honest i would just close this and go for the other PR. I've tested it extensively and everything seems to work fine. |
|
#1764 should close this if that one is merged |
Breaking change: electron/electron#28550 Child windows no longer inherit BrowserWindow construction options from their parents.
PikachuEXE
force-pushed
the
upgrade/electron-14
branch
from
175139a
to
8989962
Compare
auto-merge was automatically disabled
November 10, 2021 14:51
Pull request was closed
efb4f5ff-1298-471a-8973-3d47447115dc
added
PR: dependencies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Type
Please select what type of pull request this is:
Related issue
N/A
Description
Upgrade electron 13.x > 14.x AND fix the issue caused by a breaking change in electron 14
Breaking change:
electron/electron#28550
Child windows no longer inherit BrowserWindow construction options from their parents.
Screenshots (if appropriate)
Nothing visible should really changed
Testing (for code that is not small enough to be easily understandable)
All Dev team members should test this in
npm run dev) and built version afterward (can trigger nightly build manually)Desktop (please complete the following information):
Additional context
The upgrade had caused issue like #1636
References: