Allow specification of custom detectors + readme update #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BenSower
reviewed
Jul 14, 2023
core.js
Outdated
| @@ -59,9 +59,23 @@ function _check(buffer, headers, options) { | |||
| return true; | |||
| } | |||
|
|
|||
| export async function fileTypeFromTokenizer(tokenizer) { | |||
| async function runCustomDetectors(tokenizer, fileType, detectors) { | |||
| if (!detectors || detectors.length === 0) { | |||
There was a problem hiding this comment.
Code-Style: I would invert the condition to simplify this block and make it even cleaner to read:
if (detectors && detectors.length) {
for (const detector of detectors) {
fileType = detector(tokenizer, fileType);
}
}
return fileType;
Nit: It might be noteworthy, that right now, it could happen that if there are (for whatever reason) multiple detectors that either claim to have detected the file-type they were built for or are not properly looping through the previous fileType variable, the last detector in the array will overwrite the previous ones. I don't think that this is likely, but intuitively (and potentially also to improve performance in case you have a lot of detectors), I would expect the detection to stop after the first positive result.
|
Closed in favor of this PR, which is the real thing now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #340