Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken indentation and make lang attribute consistent in svelte-typescript template #3374

Closed
wants to merge 2 commits into from

Conversation

angryziber
Copy link
Contributor

Changes

I start from this template often and everytime the broken formatting makes me sad.
No code changes, only removal of extra indents.

@angryziber angryziber requested a review from a team as a code owner May 26, 2021 20:00
@vercel
Copy link

vercel bot commented May 26, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/pikapkg/snowpack/A7Y1d4JCMQUZXSHUvEodYewpaeTS
✅ Preview: https://snowpack-git-fork-angryziber-patch-1-pikapkg.vercel.app

Copy link
Collaborator

@drwpow drwpow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for fixing this! I’m on board with this change. But it seems that tests aren’t passing.

Could you rebase off latest main, and run the tests with yarn test -u, and commit the snapshots? We test the template snapshots on every PR to make sure that our templates are still working, and you’ll need to update those because of your changes. Once tests are passing, I’d be happy to merge this.

@drwpow
Copy link
Collaborator

drwpow commented Jun 16, 2021

Just checking in on this. Are you able to get the tests passing? If not, I can open up a new PR with these changes so we still get these live.

@drwpow drwpow mentioned this pull request Jun 29, 2021
@drwpow
Copy link
Collaborator

drwpow commented Jun 29, 2021

Moved here 👉🏻 #3511

@drwpow drwpow closed this Jun 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants