Allow creating dev server without opening port. #2314
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/pikapkg/snowpack/91vqbyo3q |
|
The failed unit test is caused by another bug. |
|
Test failures are fixed in this PR #2328 |
added 2 commits
January 16, 2021 11:35
Added a config for `devOptions.server?: boolean` which defaults to `true`; If `false`, then no http(s) server will be created and it will be up to the caller to create the initial server. Created a stub for EsmHmrEngine that avoids any processing if HMR is disabled.
|
rebased to keep up with @FredKSchott speedy fixes |
|
Fixed in #2707 by passing port = 0 (will add some docs for this). In the next breaking change for Snowpack, I'd like to add a |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a config for
devOptions.server?: booleanwhich defaults totrue;If
false, then no http(s) server will be created and it will be up tothe caller to create the initial server.
Created a stub for EsmHmrEngine that avoids any processing if HMR is disabled.
Changes
Testing
TODO: Add Tests
Docs
TODO: Update Docs