Fix #2088: unbreak automatic reinstall of linked dependencies on change #2091
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/pikapkg/snowpack/ib25ba2vb [Deployment for 699a00e failed] |
…ies on change * snowpack/src/commands/dev.ts (installDependencies): import it. (onDepWatchEvent): Call it. * snowpack/src/sources/local-install.ts (InstallRunResult): export it. * snowpack/src/sources/local.ts (InstallRunResult): import it. (installDependencies): export it and give it a type.
joaotavora
force-pushed
the
fix/fix-2088-unbreak-reinstall-of-linked-deps
branch
from
5390f7d
to
0024b55
Compare
|
I rebase this on top of |
Otherwise it's really easy to blow up the FS watcher limit. * snowpack/src/commands/dev.ts: (startServer::depWatcher): Also ignore stuff in config.exclude.
This is done rather brutally by clearing all the cache, but could probably be done more criteriously. * snowpack/src/commands/dev.ts (startServer::handleRequest): Improve debug log message. (startServer::handleRequest): Clear knownETags.
|
Thanks to work done in #2707 this is now handled automatically by Snowpack. |
|
Nice. I switched to Vite a long time ago, where this is handled perfectly, who knows maybe I'll try Snowpack again someday. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
snowpack/src/commands/dev.ts (installDependencies): import it.
(onDepWatchEvent): Use it.
snowpack/src/commands/install.ts (InstallRunResult): export it.
snowpack/src/sources/local.ts (InstallRunResult): import it.
(installDependencies): export it.
Changes
This fix bug #2088, a regression. It unbreaks the automatic reinstall of linked dependencies on change, which was lost after commit 610fb9d.
Testing
Not extensively tested I must say. I manually tested by changing the file of a single linked dependency. Anyway, the change to the code is small so it should be easy to understand what it does.
I also ran
yarn testfrom the console. i got a single failure related to something react/svelte. I don't think i introduced that. Maybe I need some package installed or something.Docs
bug fix only. Presumably this is already documented. But if it's not, tell me and I'll see to it. I write decent documentation.