Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

馃悰 BUG: Need to release & depend on esinstall v1.1.8 (AKA: Builds still broken on Windows.) #3853

Open
1 task done
NfNitLoop opened this issue Jan 29, 2022 · 0 comments

Comments

@NfNitLoop
Copy link

NfNitLoop commented Jan 29, 2022

Quick checklist

  • I am using the latest version of Snowpack and all plugins.

What package manager are you using?

npm

What operating system are you using?

Windows

Describe the bug

I left a comment in this PR: #3606 (comment) (which claims to fix: #3545) that it doesn't actually fix the issue.

The fix

PR #3606 already bumps the rollup-plugin-pollyfill-node version to 0.7.0 for a fix. I think someone just needs to release a new version of esinstall with that new dependency, and then upgrade snowpack to depend on that.

Steps to reproduce

It's not a minimal example (I think I kept running into tree shaking optimizing away my examples), but I document some "Steps to Reproduce" here:
NfNitLoop/feoblog#16

Link to minimal reproducible example (optional)

No response

@NfNitLoop NfNitLoop changed the title 馃悰 BUG: Need to release & depend on esinstall v1.1.8 馃悰 BUG: Need to release & depend on esinstall v1.1.8 (AKA: Builds still broken on Windows.) Jan 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant