Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Snowpack attempts to use invalid file names on Windows #2752

Open
NfNitLoop opened this issue Feb 27, 2021 · 4 comments
Open

Snowpack attempts to use invalid file names on Windows #2752

NfNitLoop opened this issue Feb 27, 2021 · 4 comments

Comments

@NfNitLoop
Copy link

NfNitLoop commented Feb 27, 2021 •
edited

This is due to a bug which has been fixed in Rollup v2.40.0:

I believe if Snowpack updates to v2.40.0 this should solve the issue.
@NfNitLoop NfNitLoop changed the title Snowpack generates invalid file names on Windows Snowpack attempts to use invalid file names on Windows Feb 27, 2021
@NfNitLoop NfNitLoop mentioned this issue Feb 27, 2021
Open
7 tasks
@FredKSchott
Copy link
Owner

Thanks for filing! I'd love to let v2.40.0 settle a bit before adopting, since we've been bitten in the past by immediately updating to the latest Rollup releases. Once #2707 is out, then lets prioritize this.

@FredKSchott FredKSchott added this to Needs Triage in Triage Mar 9, 2021
@melissamcewen melissamcewen moved this from Needs Triage to Triaging in Triage Mar 10, 2021
@melissamcewen melissamcewen moved this from Triaging to Needs Triage in Triage Mar 15, 2021
@drwpow
Copy link
Collaborator

drwpow commented Apr 29, 2021

Just checking in on this, and it still seems that the most recent version of Rollup (2.46.0) still has an issue with treeshaking as outlined here: #2572. Will hold off a bit longer in updating Rollup either until this is fixed in Rollup, or we have a better workaround.

@drwpow
Copy link
Collaborator

drwpow commented Apr 29, 2021

I believe this is the issue Rollup is tracking, among other treeshaking bugs: rollup/rollup#3878

@NfNitLoop NfNitLoop mentioned this issue Jul 24, 2021
Closed
1 task
@NfNitLoop
Copy link
Author

#3853 might fix this. 🤞

@FredKSchott FredKSchott removed this from Needs Triage in Triage Apr 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@NfNitLoop @FredKSchott @drwpow