🐛 BUG: polyfillNode broken on Windows due to rollup-plugin-polyfill-node

[rossng]

Quick checklist

• I am using the latest version of Snowpack and all plugins.

What package manager are you using?

npm

What operating system are you using?

Windows

Describe the bug

During the esbuild optimize step on Windows, it throws errors like:

error: Could not resolve "./common/_polyfill-node:util-cead3761.js"

This is because the filename contains a : character, which is invalid on Windows. It seems that these filenames are generated by rollup-plugin-polyfill-node, which is used by esinstall to generate the polyfills earlier on in the Snowpack build. Instead, it creates a 0-byte file called _polyfill-node which has some NTFS alternate data streams:

[...]\_snowpack\pkg\common\_polyfill-node:
   :util-cead3761.js:$DATA      69423
   :util-cead3761.js.map:$DATA  2695

There has been a PR to fix this waiting for a month. There's also another PR that fixes a different Windows issue that I haven't encountered yet. It would be good to get these merged and released in Snowpack.

It looks like it's responsible for this issue: NfNitLoop/feoblog#16 and likely breaks most Snowpack builds on Windows.

Link to minimal reproducible example (optional)

No response

[NfNitLoop]

Related bug in Snowpack: #2752

[leruaa]

Unfortunatelly this issue is not resolved in snowpack 3.8.8 because the esinstall version has not been updated in PR #3606 and as a result the fix hasn't been deployed.