Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose an actual SHA for pull requests as CI_PR_SHA(_SHORT). #48

Merged
merged 3 commits into from Jul 16, 2022
Merged

Expose an actual SHA for pull requests as CI_PR_SHA(_SHORT). #48

merged 3 commits into from Jul 16, 2022

Commits on Jul 12, 2022

  1. Expose an actual SHA for pull requests as CI_PR_SHA(_SHORT). 

    Default CI_SHA/GITHUB_SHA is the sha of _expect-to-be_ merge/squash/etc commit of the pull requests,
and it can be very confusing. If you mark you artifacts with it, its very hard to trace back what was the actual commit.

CI_PR_SHA is the way I solved it for my use cases and I can see im not the first one with this problem.

Fixes FranzDiebold#30
    @iamstarkov
    iamstarkov committed Jul 12, 2022
    Copy the full SHA
    e59d29a View commit details
    Browse the repository at this point in the history

Commits on Jul 16, 2022

  1. Improve Makefile: Add help texts.

    @FranzDiebold
    FranzDiebold committed Jul 16, 2022
    Copy the full SHA
    2858253 View commit details
    Browse the repository at this point in the history

  2. Prepare for release.

    @FranzDiebold
    FranzDiebold committed Jul 16, 2022
    Copy the full SHA
    d144085 View commit details
    Browse the repository at this point in the history