Fix pulling up Value
through Ordering
#1906
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When pulling up a
Value
throughOrdering
, it is possible that we do not clean up dependency lineage (found through the transitive closure) correctly if we don't find a dependency target in the pulled upValue
.This causes some plan partitions to misrepresent their order causing Cascades to fail to plan some queries due to not being able to satisfy their ordering requirement because of that.
It fixes #1905.