Resolves #1636: Increase FDB Java version to FDB 7.1 #1641
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AWS CodeBuild CI Report for Linux CentOS 7
|
AWS CodeBuild CI Report for Linux CentOS 7
|
alecgrieser
force-pushed
the
api-version-7.1
branch
from
17c0c1a
to
8af1263
Compare
|
Rebase addresses merge conflicts (which were in |
AWS CodeBuild CI Report for Linux CentOS 7
|
AWS CodeBuild CI Report for Linux CentOS 7
|
This increases the FDB Java dependency to FDB 7.1. This keeps the API version at 630 so that the library can still be used to connect to FDB 6.3 and FDB 7.0 clusters, though it would now require using a 7.1 FDB C client as the primary client with the other clients as external clients. This will allow for additional features to be built on top of FDB 7.1, though we probably want to also complete FoundationDB#1639 so that we can responsibly guard features reliant on 7.1 in environments where the cluster may still be running older FDB server versions.
This updates the proto3 version to 3.20.1 and updates a few other dependencies as well. It leaves the guava version at 30.1-jre instead of updating it to 31.1-jre because that causes spotbugs violations regarding nullability problems. I think those errors are because of a possible change in the way Guava handles nullability annotations, but it seems like something we should fix later.
alecgrieser
force-pushed
the
api-version-7.1
branch
from
8af1263
to
4587f11
Compare
|
Rebase to resolve build failures from #1643 |
AWS CodeBuild CI Report for Linux CentOS 7
|
AWS CodeBuild CI Report for Linux CentOS 7
|
MMcM
requested changes
May 4, 2022
ohadzeliger
reviewed
May 4, 2022
| return underlying.getMappedRange(begin, end, mapper, limit, reverse, mode); | ||
| } | ||
|
|
||
| @Override |
There was a problem hiding this comment.
Do we know for certain that no counters should be incremented for these calls? (for getMappedRange work has been done on the index prefetch branch, but I am not aware of similar work for the getRangeSplitPoints)
There was a problem hiding this comment.
I'm...not sure, actually. It looks like that method probably uses the byte sample to get an estimate for relatively equally sized key ranges. My instinct was to treat these like getEstimatedRangeSizeBytes as of a similar type, and leave it uninstrumented. That being said, I'm not opposed to adding instrumentation here, either in this PR or in a follow up.
There was a problem hiding this comment.
Sure. We can leave uninstrumented and change in followup PR.
MMcM
previously approved these changes
May 4, 2022
AWS CodeBuild CI Report for Linux CentOS 7
|
AWS CodeBuild CI Report for Linux CentOS 7
|
ohadzeliger
previously approved these changes
May 4, 2022
alecgrieser
force-pushed
the
api-version-7.1
branch
from
96b13a7
to
e5536c7
Compare
|
Recommitting identical last commit to re-trigger sonar analysis 🥲 |
|
Kudos, SonarCloud Quality Gate passed! |
AWS CodeBuild CI Report for Linux CentOS 7
|
AWS CodeBuild CI Report for Linux CentOS 7
|
MMcM
approved these changes
May 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This increases the FDB Java dependency to FDB 7.1. This keeps the API version at 630 so that the library can still be used to connect to FDB 6.3 and FDB 7.0 clusters, though it would now require using a 7.1 FDB C client as the primary client with the other clients as external clients.
This will allow for additional features to be built on top of FDB 7.1, though we probably want to also complete #1639 so that we can responsibly guard features reliant on 7.1 in environments where the cluster may still be running older FDB server versions.
This also updates the proto3 version to 3.20.1 and along with a few other dependencies. It leaves the guava version at 30.1-jre instead of updating it to 31.1-jre because that causes spotbugs violations regarding nullability problems. I think those errors are because of a possible change in the way Guava handles nullability annotations, but it seems like something we should fix later.
This resolves #1636, and it resolves #1640.