Client-side JS performance optimizations #9272
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Introduced in: f157ea3 Due to an inverted condition, if the user is logged out, we would update the user's timezone context and cookie even if it wasn't changed.
<ExpandableSection> was rendering its (conceptual) children via a referentially-unstable wrapper component, so any rerenders propagating from above would cause a rerender-from-scratch with loss of state. One of the places this is used is QuickTakesSection, which contains a CkEditor comment editor. What this meant in practice is that on load, CkEditor would initialize twice on the client, duplicating a bunch of plugin-initialization work.
The way wrapCkEditor was written, you have to import (and trigger some plugin initialization for) every version of the editor (comment, post, and collaborative), regardless of which you're going to use. Make it so that you only set up the config for the one you're going to use, and memoize the config initialization.
This prevents downstream rerenders on pageload, saving some JS execution time.
b0b3rt
reviewed
May 13, 2024
| import { Components, registerComponent } from "../../lib/vulcan-lib"; | ||
| import PropTypes from 'prop-types'; | ||
|
|
||
| const styles = (theme: ThemeType): JssStyles => ({ |
There was a problem hiding this comment.
avoid returning JssStyles, so that classes can be typed classes: ClassesType<typeof styles> (even though there aren't any styles in this case)
There was a problem hiding this comment.
Oops, this file wasn't supposed to be in this commit at all (it was hanging out in my working directory from an unrelated thing)
…to client-js-optimizations
jpaddison3
approved these changes
May 17, 2024
There was a problem hiding this comment.
(@Will-Howard I think you forgot to make your review an approving one)
…to client-js-optimizations
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduced in: f157ea3
Due to an inverted condition, if the user is logged out, we would update
the user's timezone context and cookie even if it wasn't changed.
was rendering its (conceptual) children via a
referentially-unstable wrapper component, so any rerenders propagating
from above would cause a rerender-from-scratch with loss of state. One
of the places this is used is QuickTakesSection, which contains a
CkEditor comment editor. What this meant in practice is that on load,
CkEditor would initialize twice on the client, duplicating a bunch of
plugin-initialization work.
The way wrapCkEditor was written, you have to import (and trigger some
plugin initialization for) every version of the editor (comment, post,
and collaborative), regardless of which you're going to use.
Make it so that you only set up the config for the one you're going to
use, and memoize the config initialization.
This prevents downstream rerenders on pageload, saving some JS execution
time.
┆Issue is synchronized with this Asana task by Unito