Fix bundle/stylesheet preload for AF-to-LW crossposts #9270
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When we start loading a post page, before we start rendering it in an SSR, we sometimes send the part of the header that tells the client to start downloading the stylesheet and javascript bundle. Before we can send that, we need to be sure the request is going to result in an http 200 (ie, not a 404 or a redirect). This is handled by `PostsRepo.postRouteWillDefinitelyReturn200`. However, this handled the AF flag incorrectly; rather than checking whether the user is loading a non-AF post on AF (which would trigger a redirect), it checks whether the user is loading an AF post (which can happen on either LW or AF, and will not trigger a redirect). This meant that AF posts didn't get the bundle/stylesheet preload, making them slower.
b0b3rt
reviewed
May 12, 2024
| @@ -63,14 +63,16 @@ class PostsRepo extends AbstractRepo<"Posts"> { | |||
| } | |||
|
|
|||
| async postRouteWillDefinitelyReturn200(id: string): Promise<boolean> { | |||
| const maybeRequireAF = isAF ? "AND af=true" : "" | |||
There was a problem hiding this comment.
Might be a pre-existing issue, but should this be af IS TRUE?
There was a problem hiding this comment.
AFAIK these are equivalent (I tried select count(*) from "Posts" where af=true and the same with is true just now, and got the same result). We do seem to be favoring IS TRUE as a convention, though, so I'll change it for consistency's sake.
There was a problem hiding this comment.
The difference is that SELECT NULL IS TRUE returns FALSE, but SELECT NULL = TRUE returns NULL.
b0b3rt
approved these changes
May 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we start loading a post page, before we start rendering it in an SSR, we sometimes send the part of the header that tells the client to start downloading the stylesheet and javascript bundle. Before we can send that, we need to be sure the request is going to result in an http 200 (ie, not a 404 or a redirect). This is handled by
PostsRepo.postRouteWillDefinitelyReturn200. However, this handled the AF flag incorrectly; rather than checking whether the user is loading a non-AF post on AF (which would trigger a redirect), it checks whether the user is loading an AF post (which can happen on either LW or AF, and will not trigger a redirect). This meant that AF posts didn't get the bundle/stylesheet preload, making them slower.┆Issue is synchronized with this Asana task by Unito