Fix collab-editor crash with realtimecollaborationclient-editor-setdata-and-editor-data-set-are-forbidden-in-real-time-collaboration #9259
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hackily fix a crash in the CkEditor collaborative editor, which happens in a race-condition-like circumstance of some sort.
This works very hackily, by making the
ReactCKEditorWrapper
ignore downward-flowing changes to itsdata
prop, if collaborative editing is enabled. This means that changes to the contents of the editor can't be initiated from outside the editor. It turns out that cases where collab-editing is enabled, and cases where we need to edit the editor contents from outside, don't overlap very much, so this should be ok.┆Issue is synchronized with this Asana task by Unito