Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix collab-editor crash with realtimecollaborationclient-editor-setdata-and-editor-data-set-are-forbidden-in-real-time-collaboration #9259

Merged
merged 2 commits into from
May 16, 2024

Conversation

jimrandomh
Copy link
Collaborator

@jimrandomh jimrandomh commented May 9, 2024

Hackily fix a crash in the CkEditor collaborative editor, which happens in a race-condition-like circumstance of some sort.

This works very hackily, by making the ReactCKEditorWrapper ignore downward-flowing changes to its data prop, if collaborative editing is enabled. This means that changes to the contents of the editor can't be initiated from outside the editor. It turns out that cases where collab-editing is enabled, and cases where we need to edit the editor contents from outside, don't overlap very much, so this should be ok.

┆Issue is synchronized with this Asana task by Unito

…ta-and-editor-data-set-are-forbidden-in-real-time-collaboration
@jimrandomh jimrandomh requested a review from a team as a code owner May 9, 2024 19:18
@jimrandomh jimrandomh requested review from jpaddison3 and removed request for a team May 9, 2024 19:18
@jpaddison3 jpaddison3 self-assigned this May 9, 2024
Copy link
Collaborator

@jpaddison3 jpaddison3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks fine, I'm deferring to you that we don't have any load bearing places where the data object is being set on a collab editor.

Please fix the lint error.

@jpaddison3 jpaddison3 assigned jimrandomh and unassigned jpaddison3 May 10, 2024
@jimrandomh jimrandomh merged commit c53b1aa into master May 16, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants