Preload scaffolds for an almost-instant-loading user profile page #9172
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jpaddison3
approved these changes
Apr 25, 2024
Comment on lines
+130
to
+133
| } & ( | ||
| { sequence: SequencesPageFragment, placeholder?: false } | ||
| | { sequence: null, placeholder: true } | ||
| )) => { |
There was a problem hiding this comment.
This doesn't actually do the type checking you want it to. Something in our component registration mucks with it.
| showAuthor={showAuthor} | ||
| bookItemStyle={bookItemStyle} | ||
| />)} | ||
| {!sequences && placeholderCount!==undefined && range(0, placeholderCount) |
There was a problem hiding this comment.
I can't get this to render the loading state. I see the entire section giving me the loading spinner every time.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve the loading states of the user profile page. This started with the observation that the drafts list was picking up a
limit: 20and displaying more post-placeholders than it should. I fixed that, and went a little further and also made aSequencesGridItemplaceholder, and used the userpostCountandsequenceCountfields to get things to line up.I also did most of the setup for
UsersProfileto have an instant-load from the Apollo cache, similar to the instant-load experience you get on post pages. However, there is still one server round trip spent with a blank page and a loading spinner, because to get a user out of the apollo cache we need the user _id, but the URL contains only the user slug, and I didn't manage to find an easy way to convert without a server round trip.┆Issue is synchronized with this Asana task by Unito