Fix all time view of author analytics for old users #9156
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Will-Howard
commented
Apr 24, 2024
| @@ -191,7 +191,6 @@ addGraphQLResolvers({ | |||
| const INDIRECTLY_SORTABLE_FIELDS = ["views", "reads"]; | |||
|
|
|||
| const { currentUser } = context; | |||
| const analyticsDb = getAnalyticsConnectionOrThrow(); | |||
There was a problem hiding this comment.
These were unused
|
Discovered a off by one error in time ranges where there is no date, drafting for now |
|
@Will-Howard FYI I'm taking myself off of this PR since I'm going on vacation |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes an issue where the "all time" view for users with very old accounts would start before there was any data (reported in slack). This is because we didn't start collecting views/reads data until later, and it was including any range for which there was karma or comment data. Now it only uses the range where there is data for the fields that are selected (out of ["views", "reads", "karma", "comments"])
┆Issue is synchronized with this Asana task by Unito